Fix --files arg being wrapped in spurious quotes in presubmit.js#34298
Merged
AlexeyBarabash merged 1 commit intomasterfrom Feb 28, 2026
Merged
Fix --files arg being wrapped in spurious quotes in presubmit.js#34298AlexeyBarabash merged 1 commit intomasterfrom
AlexeyBarabash merged 1 commit intomasterfrom
Conversation
Resolves brave/brave-browser#53237 AI assisted commit
Contributor
📋 Code Owners Summary1 file(s) changed, 1 with assigned owners 1 team(s) affected: Owners and Their Files
|
Contributor
|
The security team is monitoring all repositories for certain keywords. This PR includes the word(s) "password" and so security team members have been added as reviewers to take a look. |
netzenbot
approved these changes
Feb 28, 2026
goodov
approved these changes
Feb 28, 2026
Member
goodov
left a comment
goodov
left a comment
There was a problem hiding this comment.
I think it worked on windows, but I never tested it on other platforms. lgtm!
Collaborator
|
Released in v1.89.89 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#53237
This PR fixes
--filesargument fornpm run presubmitcommand.The problem was that after passing the semicolon-separated list of paths - the first and the last args were missing from the actual checks.
Test plan:
on current
masterrunit should be displayed
Found 3 file(s).and the warnings must be from 3 files.